GolemsGolems
Skills LibraryView on GitHub
Development

/pr-loop

Full PR loop plus the agent-identity signature on GitHub writes. Triggers: create PR, finish work, post PR comment, sign a comment, golem-id, Co-Authored-By trailer.

$ golems-cli skills install pr-loop
17 evals
fixtures

Updated yesterday

Fleet law: canon #2 owns branch→commit→push→PR→review→merge and PR URL validity. This skill owns the procedural loop, review handling, edge cases, and worker-vs-lead endpoint mechanics.

Ownership

Who implements and who opens the inner-loop reviewer pane is owned by /agent-routing § Routing rules (SSOT). Never start that reviewer yourself unless that routing law makes you the owner.

This skill begins at branch preparation and ends at the authority-appropriate endpoint:

  • Lead: reviewed, latest-head-green PR merged, released/installed where applicable, verified, and cleaned up.
  • Worker whose brief says the lead owns merge: ready-for-review PR, review responses addressed, URL handed to the lead, unmerged.
  • A worker must hand the reviewed PR to its lead unmerged.

Before closing either endpoint, run scripts/ci/release-gate.mjs <repo>. MERGED_UNRELEASED, RELEASED_UNINSTALLED, or UNKNOWN is a stop; release/install and rerun until CLEAN.

Required Sequence

Keep these as four explicit turns:

  1. Fix.
  2. Commit, push, and open or update the ready-for-review PR.
  3. Babysit CI and reviews to green on the latest commit; answer findings and re-push.
  4. Merge only when the dispatch authority permits it.

When stopping early, state the completed step, PR URL/state, and exact next turn. A DONE signal is not a receipt.

Run the loop in this order:

  1. Confirm expected branch/worktree and sanitize repository state.
  2. Implement under repository law and run the relevant tests.
  3. Invoke /never-fabricate; add real-client or visual proof when triggered.
  4. Run the bounded local CodeRabbit pre-commit pass when available, then commit with the ratified identity trailer.
  5. Push, create a non-draft PR with a signed body, and apply exactly one size:* label.
  6. Apply the target repo's bot policy, invoke allowed PR reviewers, and wait for evidence.
  7. Classify every finding; fix real bugs, reply to every CRITICAL/MAJOR/HIGH finding, push, and request re-review.
  8. Confirm required checks and reviews are green on headRefOid, then either hand off unmerged or merge.
  9. After an authorized merge, verify the remote merge/content, release/install/live-probe as required, update tracking, and clean up. End the merge comment or DONE report with the CLEANUP RECEIPT.

Hard Gates

  • Never merge with zero reviews. Waiting 15 minutes does not waive the review gate; merge only after at least one review and the required review conditions pass.
  • Draft PRs silently skip bot reviews. Mark the PR ready before invoking reviewers.
  • A green run on an older SHA is not green. Verify the PR head matches the latest pushed commit.
  • Never merge with an unreplied CRITICAL, MAJOR, or HIGH finding.
  • Two review rounds are the normal minimum; three is the maximum for new non-critical findings.
  • On EtanHey repos, bot verdicts are comments, not formal self-reviews.
  • Repo bot policy tightens the fleet default panel. Bugbot is opt-in only for daemon/engine/transport diffs.
  • Cursor diff passes are read-only: findings only, never edit the PR branch. Routing: see /agent-routing § Routing rules (SSOT).
  • --body on gh pr merge sets the MERGE COMMIT message, not the PR description.
  • "git log is where you look when you already know something is wrong; the PR page is where you look to find out." Put actionable receipts in the PR body before merge.
  • PR-referenced artifacts must be committed or quoted inline; gitignored docs.local/ paths alone are not reviewable.
  • R-010 keeps merge commits as the default until the commit-traceability condition is discharged in the canonical registry.
  • Daemon/socket/MCP/protocol changes require a real client session; unit tests, socat, and curl are insufficient.
  • Human-visible changes require builder-driven visual QA in a real running state, or an explicit not-performed caveat.
  • Before a done/deployed/green claim, run the applicable false-green/deploy/QA gates and make the required live probe.
  • Never place real client data in public PR text, fixtures, comments, or commit messages.
  • Never delete a stacked PR's base branch before its children are retargeted and mergeable.
  • Never merge or clean up from the linked worktree holding the active session.